Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update BFS and SSSP to check start/source vertex for validity #2268

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented May 11, 2022

Adds a check in BFS and SSSP to ensure that the start vertex is a valid vertex in the provided graph. Returns a ValueError if the start vertex is invalid. Closes #1587

@alexbarghi-nv alexbarghi-nv requested review from a team as code owners May 11, 2022 14:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alexbarghi-nv alexbarghi-nv marked this pull request as draft May 11, 2022 14:16
@alexbarghi-nv alexbarghi-nv changed the title WIP: Update BFS and SSSP to check start/source vertex for validity WIP: [BUG] Update BFS and SSSP to check start/source vertex for validity May 11, 2022
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 11, 2022 14:30
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change python labels May 11, 2022
@alexbarghi-nv alexbarghi-nv marked this pull request as draft May 11, 2022 15:35
@alexbarghi-nv alexbarghi-nv changed the title WIP: [BUG] Update BFS and SSSP to check start/source vertex for validity [BUG] Update BFS and SSSP to check start/source vertex for validity May 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #2268 (6e02fd5) into branch-22.06 (38be932) will decrease coverage by 1.07%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2268      +/-   ##
================================================
- Coverage         70.82%   69.75%   -1.08%     
================================================
  Files               170      175       +5     
  Lines             11036    11495     +459     
================================================
+ Hits               7816     8018     +202     
- Misses             3220     3477     +257     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 88.23% <ø> (-1.24%) ⬇️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 85.29% <ø> (ø)
...cugraph/cugraph/dask/centrality/katz_centrality.py 25.00% <ø> (ø)
python/cugraph/cugraph/dask/common/input_utils.py 22.13% <ø> (+0.57%) ⬆️
python/cugraph/cugraph/dask/common/mg_utils.py 30.43% <ø> (-7.07%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc22420...6e02fd5. Read the comment docs.

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 16, 2022 12:34
@BradReesWork BradReesWork requested a review from rlratzel May 16, 2022 18:30
@BradReesWork BradReesWork requested a review from jnke2016 May 16, 2022 18:30
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for also adding the additional tests.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1489712 into rapidsai:branch-22.06 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid start vertex for MG BFS and MG SSSP result in unclear exception
4 participants