Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GraphStore Function #2183

Merged
merged 22 commits into from
Apr 16, 2022
Merged

Added GraphStore Function #2183

merged 22 commits into from
Apr 16, 2022

Conversation

wangxiaoyunNV
Copy link
Contributor

I added a neighbor_sampler function to the graph store class.

@wangxiaoyunNV wangxiaoyunNV requested a review from a team as a code owner March 31, 2022 19:58
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 4, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Apr 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #2183 (8e87c83) into branch-22.06 (017baab) will decrease coverage by 1.36%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #2183      +/-   ##
================================================
- Coverage         72.41%   71.05%   -1.37%     
================================================
  Files               157      170      +13     
  Lines             10496    11099     +603     
================================================
+ Hits               7601     7886     +285     
- Misses             2895     3213     +318
Impacted Files Coverage Δ
python/cugraph/cugraph/gnn/graph_store.py 82.60% <100.00%> (+11.77%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <100.00%> (+1.56%) ⬆️
...tests/dask/test_mg_batch_betweenness_centrality.py 0.00% <0.00%> (-86.96%) ⬇️
.../dask/test_mg_batch_edge_betweenness_centrality.py 0.00% <0.00%> (-86.37%) ⬇️
...thon/cugraph/cugraph/tests/dask/test_mg_louvain.py 0.00% <0.00%> (-41.94%) ⬇️
...ython/cugraph/cugraph/tests/dask/test_mg_degree.py 0.00% <0.00%> (-41.67%) ⬇️
...cugraph/cugraph/tests/dask/test_mg_connectivity.py 0.00% <0.00%> (-34.49%) ⬇️
python/cugraph/cugraph/tests/dask/test_mg_sssp.py 0.00% <0.00%> (-33.34%) ⬇️
.../cugraph/cugraph/tests/dask/test_mg_replication.py 0.00% <0.00%> (-33.34%) ⬇️
...thon/cugraph/cugraph/tests/dask/test_mg_utility.py 0.00% <0.00%> (-29.86%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017baab...8e87c83. Read the comment docs.

@BradReesWork
Copy link
Member

rerun tests

BradReesWork
BradReesWork requested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more expansive test cases

  • test ndata
  • test edata
  • test sampling

@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit da07cad into rapidsai:branch-22.06 Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.
3 participants
@wangxiaoyunNV @codecov-commenter @BradReesWork