Add CMake install rules for tests
#2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2057 +/- ##
===============================================
Coverage ? 73.39%
===============================================
Files ? 155
Lines ? 10231
Branches ? 0
===============================================
Hits ? 7509
Misses ? 2722
Partials ? 0 Continue to review full report at Codecov.
|
robertmaynard
suggested changes
Feb 3, 2022
| @@ -133,6 +133,15 @@ function(ConfigureTest CMAKE_TEST_NAME) | |||
| endif(OpenMP_CXX_FOUND) | |||
There was a problem hiding this comment.
The following targets need to be installed as well:
- targets made via ConfigureTestMG()
- targets made via ConfigureCTest()
There was a problem hiding this comment.
@robertmaynard, unless I'm mistaken, I think I've already covered those targets here. I just rebased on the latest changes and pushed a commit to update the DESTINATION and RPATH path for each target.
This PR adds a CMake `install` rule for test targets. This step is a prerequisite to being able to package tests in their own `conda` package, which will enable us to deprecate _Project Flash_.
ajschmidt8
force-pushed
the
add-install-rules
branch
from
7ff96a4 to
11ab457
Compare
robertmaynard
approved these changes
Feb 7, 2022
rlratzel
approved these changes
Feb 7, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CMake
installrule for test targets. This step is a prerequisite to being able to package tests in their owncondapackage, which will enable us to deprecate Project Flash.