Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ccache with sccache #2045

Merged
merged 10 commits into from
Feb 3, 2022
Merged

replace ccache with sccache #2045

merged 10 commits into from
Feb 3, 2022

Conversation

AyodeAwe
Copy link
Contributor

This PR replaces ccache with sccache.

@AyodeAwe AyodeAwe requested a review from a team as a code owner January 27, 2022 22:12
@AyodeAwe AyodeAwe added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 27, 2022
@AyodeAwe AyodeAwe marked this pull request as draft January 27, 2022 22:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@2b95059). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2045   +/-   ##
===============================================
  Coverage                ?   73.34%           
===============================================
  Files                   ?      155           
  Lines                   ?    10002           
  Branches                ?        0           
===============================================
  Hits                    ?     7336           
  Misses                  ?     2666           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b95059...9e82061. Read the comment docs.

@AyodeAwe AyodeAwe changed the base branch from branch-22.02 to branch-22.04 January 28, 2022 16:41
@ajschmidt8
Copy link
Member

pre-cache C++ build time (log link): 1:47:12.4

image

@ajschmidt8
Copy link
Member

post-cache C++ build time (log link): 0:02:18.3

image

@AyodeAwe
Copy link
Contributor Author

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@ajschmidt8 ajschmidt8 marked this pull request as ready for review February 2, 2022 17:29
@ajschmidt8 ajschmidt8 added DO NOT MERGE Hold off on merging; see PR for details and removed DRAFT labels Feb 2, 2022
@ajschmidt8
Copy link
Member

PR is ready for review, but we'll wait to merge until all the other PRs are confirmed working as well.

ajschmidt8
ajschmidt8 requested changes Feb 2, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the recipe below as well.

@ajschmidt8 ajschmidt8 removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 2, 2022
@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e991dbd into rapidsai:branch-22.04 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyodeAwe @codecov-commenter @ajschmidt8 @BradReesWork