Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created initial list of simple Graph creation tests for nx compatibility #2035

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Created initial list of simple Graph creation tests for nx compatibility #2035

merged 4 commits into from
Feb 8, 2022

Conversation

acostadon
Copy link
Contributor

No description provided.

@acostadon acostadon added UX DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9bc960e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2035   +/-   ##
===============================================
  Coverage                ?   73.55%           
===============================================
  Files                   ?      156           
  Lines                   ?    10295           
  Branches                ?        0           
===============================================
  Hits                    ?     7573           
  Misses                  ?     2722           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc960e...33f83b8. Read the comment docs.

@BradReesWork BradReesWork changed the base branch from branch-22.02 to branch-22.04 January 26, 2022 17:04
@BradReesWork BradReesWork added this to the 22.04 milestone Jan 26, 2022
rlratzel
rlratzel reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, I have just one suggestion.

python/cugraph/cugraph/tests/test_nx_compatibility.py Outdated Show resolved Hide resolved
@rlratzel rlratzel marked this pull request as ready for review February 4, 2022 16:41
@rlratzel rlratzel requested review from a team as code owners February 4, 2022 16:41
@ajschmidt8
Copy link
Member

@acostadon, can you merge in the latest changes from branch-22.04? The ops-codeowners team is getting flagged to review changes that have already been merged.

@acostadon acostadon removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 4, 2022
@rlratzel rlratzel removed request for a team February 4, 2022 18:23
@rlratzel rlratzel mentioned this pull request Feb 6, 2022
Closed
35 tasks
@rlratzel rlratzel added the python label Feb 7, 2022
@rlratzel
Copy link
Contributor

rlratzel commented Feb 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8a5df26 into rapidsai:branch-22.04 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork Awaiting requested review from BradReesWork

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
5 participants
@acostadon @codecov-commenter @ajschmidt8 @rlratzel @BradReesWork