Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collections.abc.Sequence instead of deprecated collections.Sequence. #1932

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 5, 2021

Hi cuGraph team! I was looking at a couple things across RAPIDS related to Python 3.10 compatibility. There is one spot where the deprecated name collections.Sequence is used. This was moved to collections.abc.Sequence in Python 3.3 and has been deprecated for a while. In Python 3.10 the deprecated names for abstract base classes like collections.Sequence were removed.

This PR fixes that module path to help with eventual compatibility with Python 3.10+. I think this is the only instance of this deprecated name across RAPIDS packages.

(I don't have permissions to set labels or project boards, so the label checker will fail until someone else does that.)

@bdice bdice requested a review from a team as a code owner November 5, 2021 21:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@3840ef6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1932   +/-   ##
===============================================
  Coverage                ?   70.42%           
===============================================
  Files                   ?      143           
  Lines                   ?     8913           
  Branches                ?        0           
===============================================
  Hits                    ?     6277           
  Misses                  ?     2636           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3840ef6...b066ff6. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @bdice

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2021
@rlratzel
Copy link
Contributor

rlratzel commented Nov 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3cf4d86 into rapidsai:branch-21.12 Nov 7, 2021
@bdice bdice deleted the fix-collections-import branch November 7, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants