Additional improvements to support (key, value) pairs when E/V is small and P is large #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of std::optional<rmm::device_uvector<vertex_t>>
seunghwak
added
DO NOT MERGE
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1919 +/- ##
===============================================
Coverage ? 69.57%
===============================================
Files ? 143
Lines ? 8674
Branches ? 0
===============================================
Hits ? 6035
Misses ? 2639
Partials ? 0 Continue to review full report at Codecov.
|
seunghwak
added
3 - Ready for Review
and removed
DO NOT MERGE
ChuckHastings
approved these changes
Nov 8, 2021
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls updates from #1916 & #1917. Better be reviewed after #1916 ݽ gets merged.
(key, value) pairs are still disabled (by setting the threshold value to 0) as this has performance overhead and no clear benefit in analyzing larger graphs up to 32 GPUs (unless we artificially tweak 2D partitioning of GPUs). The threshold value needs to be adjusted with larger scale testing later.