Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WCC test until we get get on an A100 to debug on #1870

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

ChuckHastings
Copy link
Collaborator

CI testing on A100 is detecting a segmentation fault in the WCC implementation. We currently can't get developer access to an A100 in order to debug this. This PR will disable the WCC test. Once we can resolve the A100 issue we can enable this test again.

@ChuckHastings ChuckHastings requested a review from a team as a code owner October 6, 2021 17:31
@ChuckHastings ChuckHastings self-assigned this Oct 6, 2021
@ChuckHastings ChuckHastings added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Oct 6, 2021
@ChuckHastings ChuckHastings added this to the 21.12 milestone Oct 6, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ChuckHastings ChuckHastings requested review from a team as code owners October 6, 2021 18:36
@ChuckHastings ChuckHastings requested a review from a team as a code owner October 6, 2021 18:39
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@1313e34). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1870   +/-   ##
===============================================
  Coverage                ?   70.11%           
===============================================
  Files                   ?      143           
  Lines                   ?     8827           
  Branches                ?        0           
===============================================
  Hits                    ?     6189           
  Misses                  ?     2638           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1313e34...581b06c. Read the comment docs.

…e part of it calls weak by default and still crashes on Ampere.
@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3af3089 into rapidsai:branch-21.12 Oct 7, 2021
rapids-bot bot pushed a commit that referenced this pull request Oct 14, 2021
#1870 disabled some tests to allow us to push some things through CI.  While investigating this issue we discovered that we are having problem compiling the code in a container that uses the delivered 11.0 thrust.

This PR is a different temporary workaround.  We force downloading the desired version of thrust to be used as part of the cugraph build.  The PR also reactivates all of the WCC testing.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #1883
@ChuckHastings ChuckHastings deleted the disable_wcc_test branch February 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants