Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] multi seeds BFS with one seed per component #1591

Merged
merged 30 commits into from
Sep 2, 2021
Merged

[REVIEW] multi seeds BFS with one seed per component #1591

merged 30 commits into from
Sep 2, 2021

Conversation

afender
Copy link
Member

@afender afender commented May 8, 2021 •
edited by rlratzel
Loading

CUDA/++ part. It builds and runs. Test check sum matches what we get from running BFS in a loop
Draft: Needs python bindings and further validation. Could be cleaned up after the next round of generator updates

@afender afender requested review from a team as code owners May 8, 2021 00:28
@afender afender marked this pull request as draft May 8, 2021 00:28
@BradReesWork BradReesWork added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change breaking Breaking change and removed non-breaking Non-breaking change labels Jun 1, 2021
@BradReesWork BradReesWork linked an issue Jun 2, 2021 that may be closed by this pull request
[FEA] Multi-source BFS with one seed per component #1487
Closed
5 tasks
@BradReesWork BradReesWork added this to the 21.08 milestone Jun 2, 2021
@BradReesWork BradReesWork changed the base branch from branch-21.06 to branch-21.08 June 2, 2021 21:44
@BradReesWork BradReesWork modified the milestones: 21.08, 21.11 Jul 7, 2021
@Iroy30 Iroy30 removed the DRAFT label Aug 16, 2021
@Iroy30 Iroy30 marked this pull request as ready for review August 16, 2021 22:51
@Iroy30 Iroy30 requested a review from a team as a code owner August 16, 2021 22:51
@BradReesWork BradReesWork changed the base branch from branch-21.08 to branch-21.10 August 16, 2021 23:14
rlratzel
rlratzel approved these changes Aug 27, 2021
View reviewed changes
cpp/include/algorithms.hpp Outdated Show resolved Hide resolved
cpp/src/experimental/bfs.cu Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #1591 (3afc9a9) into branch-21.10 (bf64c2c) will increase coverage by 12.09%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.10    #1591       +/-   ##
=================================================
+ Coverage         59.85%   71.95%   +12.09%     
=================================================
  Files                77      134       +57     
  Lines              3547     8332     +4785     
=================================================
+ Hits               2123     5995     +3872     
- Misses             1424     2337      +913
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.80% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.47% <ø> (ø)
python/cugraph/cugraph/comms/comms.py 34.52% <ø> (ø)
python/cugraph/cugraph/community/__init__.py 70.37% <ø> (ø)
python/cugraph/cugraph/community/ecg.py 100.00% <ø> (ø)
python/cugraph/cugraph/community/egonet.py 92.30% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 84.37% <ø> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89eb18...3afc9a9. Read the comment docs.

ChuckHastings
ChuckHastings reviewed Aug 30, 2021
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions

cpp/src/traversal/bfs.cu Outdated Show resolved Hide resolved
cpp/src/traversal/bfs.cu Outdated Show resolved Hide resolved
cpp/src/traversal/bfs.cu Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

rlratzel commented Sep 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 140a35f into rapidsai:branch-21.10 Sep 2, 2021
@seunghwak seunghwak mentioned this pull request Sep 2, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Sep 3, 2021
@seunghwak
Clean-up artifacts from the multi-source BFS PR (#1591) (#1804)
9056f2e 
The multi-source BFS PR (#1591) created some artifacts (listed below). This PR cleans up those.

- We assume pointers passed to main algorithms are device pointers (instead of supporting both device & host pointers).
- MG BFS tests are not updated for the API changes.
- Some clean-up in input parameter checks.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1804
@rlratzel rlratzel mentioned this pull request Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@Iroy30 Iroy30

@afender afender

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
21.10
Development

Successfully merging this pull request may close these issues.

[FEA] Multi-source BFS with one seed per component
6 participants
@afender @codecov-commenter @rlratzel @ChuckHastings @BradReesWork @Iroy30