Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push DeviceScalar construction into cython for list.contains #7864

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Push DeviceScalar construction into cython for list.contains #7864

merged 5 commits into from
Apr 6, 2021

Conversation

brandon-b-miller
Copy link
Contributor

Fixes #7854.

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner April 5, 2021 22:06
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 5, 2021
@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team bug Something isn't working Cython non-breaking Non-breaking change labels Apr 5, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 5, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 5, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #7864 (a68b446) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head a68b446 differs from pull request most recent head de1a1c7. Consider uploading reports for the commit de1a1c7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7864      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f1789...de1a1c7. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c8c00f1 into rapidsai:branch-0.19 Apr 6, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@brandon-b-miller @shwina
Push DeviceScalar construction into cython for list.contains (rapidsa…
4b2185c 
…i#7864)

Fixes rapidsai#7854.

Authors:
  - https://github.com/brandon-b-miller

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: rapidsai#7864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] list contains requires passing a device scalar
3 participants
@brandon-b-miller @kkraus14 @galipremsagar