Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass stream and user resource to make_default_constructed_scalar #7469

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

magnatelee
Copy link
Contributor

The make_default_constructed_scalar factory currently doesn't take streams or user resources, which could lead to inconsistent results if the constructed scalar is used with a non-default non-blocking stream later on. This PR is to fix the issue.

@magnatelee magnatelee requested a review from a team as a code owner February 27, 2021 00:31
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 27, 2021
@magnatelee magnatelee changed the title Pass stream user resource to make_default_constructed_scalar Pass stream and user resource to make_default_constructed_scalar Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #7469 (94073c6) into branch-0.19 (43b44e1) will increase coverage by 0.45%.
The diff coverage is 90.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7469      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.45%     
===============================================
  Files              101      101              
  Lines            16695    17244     +549     
===============================================
+ Hits             13658    14185     +527     
- Misses            3037     3059      +22     
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
python/cudf/cudf/core/_compat.py 100.00% <100.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a5ec8...94073c6. Read the comment docs.

@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Mar 3, 2021
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 3, 2021
@harrism
Copy link
Member

harrism commented Mar 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2a0be16 into rapidsai:branch-0.19 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants