Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cuFile JNI compile errors [skip ci] #7445

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Feb 25, 2021

Some cudf change caused compile errors in CuFileJni.cpp:

     [exec] In file included from /home/rou/src/cudf/java/src/main/native/src/CuFileJni.cpp:22:
     [exec] /home/rou/src/cudf/java/src/main/native/src/CuFileJni.cpp: In member function ‘void {anonymous}::cufile_file::read(const {anonymous}::cufile_buffer&, std::size_t) const’:
     [exec] /home/rou/src/cudf/java/src/main/native/src/CuFileJni.cpp:221:25: error: comparison of integer expressions of different signedness: ‘const long int’ and ‘std::size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
     [exec]   221 |     CUDF_EXPECTS(status == buffer.size(), "Size of bytes read is different from buffer size");
     [exec]       |                  ~~~~~~~^~~~~~~~~~~~~~~~
     [exec] /home/rou/src/cudf/java/src/main/native/../../../../cpp/include/cudf/utilities/error.hpp:63:7: note: in definition of macro ‘CUDF_EXPECTS’
     [exec]    63 |   (!!(cond)) ? static_cast<void>(0)                                 \
     [exec]       |       ^~~~
     [exec] /home/rou/src/cudf/java/src/main/native/src/CuFileJni.cpp: In member function ‘void {anonymous}::cufile_file::write(const {anonymous}::cufile_buffer&, std::size_t)’:
     [exec] /home/rou/src/cudf/java/src/main/native/src/CuFileJni.cpp:242:25: error: comparison of integer expressions of different signedness: ‘const long int’ and ‘std::size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
     [exec]   242 |     CUDF_EXPECTS(status == buffer.size(), "Size of bytes written is different from buffer size");
     [exec]       |                  ~~~~~~~^~~~~~~~~~~~~~~~
     [exec] /home/rou/src/cudf/java/src/main/native/../../../../cpp/include/cudf/utilities/error.hpp:63:7: note: in definition of macro ‘CUDF_EXPECTS’
     [exec]    63 |   (!!(cond)) ? static_cast<void>(0)                                 \
     [exec]       |       ^~~~
     [exec] cc1plus: all warnings being treated as errors
     [exec] make[2]: *** [CMakeFiles/cufilejni.dir/build.make:82: CMakeFiles/cufilejni.dir/src/CuFileJni.cpp.o] Error 1
     [exec] make[1]: *** [CMakeFiles/Makefile2:97: CMakeFiles/cufilejni.dir/all] Error 2

@rongou rongou added bug Something isn't working 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Feb 25, 2021
@rongou rongou requested a review from a team as a code owner February 25, 2021 00:28
@jlowe
Copy link
Member

jlowe commented Feb 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d4583ec into rapidsai:branch-0.19 Feb 25, 2021
@rongou rongou deleted the fix-cufile-jni-compile branch November 23, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants