-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in list_device_view::pair_rep_end() #7423
Fix typo in list_device_view::pair_rep_end() #7423
Conversation
The error is regretted. I noticed the problem a moment before #7349 was merged. (I was going over it one last time before commit.) |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7423 +/- ##
==============================================
Coverage ? 81.80%
==============================================
Files ? 101
Lines ? 16695
Branches ? 0
==============================================
Hits ? 13658
Misses ? 3037
Partials ? 0 Continue to review full report at Codecov.
|
Is there no test that exercises this path? |
All the |
@gpucibot merge |
#7349 introduced rep-iterators for
list_device_view
. In implementation forlist_device_view::pair_rep_end()
has a typo, and is incorrect.The change in this PR should fix the problem, and exercise the corrected implementation from
lists::contains()
.