Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve digitize API #7071

Merged
merged 6 commits into from
Jan 6, 2021
Merged

Improve digitize API #7071

merged 6 commits into from
Jan 6, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jan 4, 2021

Closes #6360

Updates digitize() API to accept any non-nullable column-like objects, as opposed to previously only np.array. Adds better error handling and further simplifies the implementation.

@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Jan 4, 2021
@isVoid isVoid requested a review from a team as a code owner January 4, 2021 23:24
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #7071 (91273b2) into branch-0.18 (6828e2c) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7071      +/-   ##
===============================================
+ Coverage        82.09%   82.11%   +0.01%     
===============================================
  Files               97       97              
  Lines            16474    16479       +5     
===============================================
+ Hits             13524    13531       +7     
+ Misses            2950     2948       -2     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 94.17% <80.00%> (-0.24%) ⬇️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6828e2c...91273b2. Read the comment docs.

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor changes requested.

Co-authored-by: Ashwin Srinath <3190405+shwina@users.noreply.github.com>
@rapids-bot rapids-bot bot merged commit c0920e6 into rapidsai:branch-0.18 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] digitize on gpu bins
2 participants