-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve digitize
API
#7071
Improve digitize
API
#7071
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7071 +/- ##
===============================================
+ Coverage 82.09% 82.11% +0.01%
===============================================
Files 97 97
Lines 16474 16479 +5
===============================================
+ Hits 13524 13531 +7
+ Misses 2950 2948 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor changes requested.
Co-authored-by: Ashwin Srinath <3190405+shwina@users.noreply.github.com>
Closes #6360
Updates
digitize()
API to accept any non-nullable column-like objects, as opposed to previously onlynp.array
. Adds better error handling and further simplifies the implementation.