Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend replace_nulls_policy to string and dictionary type #7004

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Extend replace_nulls_policy to string and dictionary type #7004

merged 1 commit into from
Dec 17, 2020

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 14, 2020

Follow up for PR #6907

  • replace_null policy function now supports string and dictionary dtype column.

Since original implementation depends only on column validity and index, this extension trivially removes SFINAE on replace_null functor and removes type_dispatcher.

@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 14, 2020
@isVoid isVoid self-assigned this Dec 14, 2020
@isVoid isVoid requested a review from a team as a code owner December 14, 2020 20:35
@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #7004 (c7eed62) into branch-0.18 (2a2b4d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.18    #7004   +/-   ##
============================================
  Coverage        82.01%   82.01%           
============================================
  Files               96       96           
  Lines            16340    16340           
============================================
  Hits             13402    13402           
  Misses            2938     2938

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2b4d6...c7eed62. Read the comment docs.

harrism
harrism requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small fix.

cpp/src/replace/nulls.cu Show resolved Hide resolved
@isVoid isVoid mentioned this pull request Dec 15, 2020
Merged
@harrism harrism added the 4 - Needs Review Waiting for reviewer to review or respond label Dec 15, 2020
@rapids-bot rapids-bot bot merged commit da60cce into rapidsai:branch-0.18 Dec 17, 2020
@isVoid isVoid mentioned this pull request Dec 17, 2020
Merged
rapids-bot bot pushed a commit that referenced this pull request Dec 18, 2020
@isVoid
Add ffill and bfill to string columns(#7036)
ae90dd9 
Follow up of PR #7004 

Adds `method` field to `fillna` method in string type column to support `ffill` and `bfill`.
Also involves a small change to a `datetime64` `ffill`, `bfill` test case to improve test robustness.

Authors:
  - Michael Wang <isVoid@users.noreply.github.com>

Approvers:
  - GALI PREM SAGAR

URL: #7036
@isVoid isVoid mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isVoid @harrism @karthikeyann @jrhemstad @davidwendt