Fix type comparison for java [skip ci] #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
bug
jlowe
approved these changes
Dec 10, 2020
jlowe
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of trying to support upper and lower bounds for decimal I found that type checking for this function was broken because it used
==for equality instead of.equals. Looking further I found a few other places where this was a bug (one in ColumnVector that is mostly a performance issue and one in Scalar) I decided to update all of the code to use .equals for comparison of types to make it consistent so it is less likely to have bugs like this crop up in the future.I also took the opportunity to internally move away from using
isTimestamp(which is deprecated) toisTimestampType