Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astype from tz-aware type to tz-aware type #16980

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #16973

Also matches astype from tz-naive to tz-aware type like pandas

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 2, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 2, 2024 19:05
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2ec6cb3 into rapidsai:branch-24.12 Oct 3, 2024
97 checks passed
@davidwendt
Copy link
Contributor

Should the title of the PR be Fix astype from tz-naive type to tz-aware type?
(Just for posterity and the changelog)

@mroeschke
Copy link
Contributor Author

mroeschke commented Oct 3, 2024

Should the title of the PR be Fix astype from tz-naive type to tz-aware type?

The larger bug is described correctly by the PR title (which is also related to the linked issue). This PR also fixes a minor bug that you're describing, Fix astype from tz-naive type to tz-aware type, where an exception should have been raised.

@mroeschke mroeschke deleted the bug/astype/tz_to_tz branch October 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] astype ignores time zone
3 participants