Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary flag from build.sh #16879

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Remove unnecessary flag from build.sh #16879

merged 3 commits into from
Sep 25, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 23, 2024

Description

This CMake option was removed by #15483.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 23, 2024
@vyasr vyasr self-assigned this Sep 23, 2024
@vyasr vyasr requested a review from a team as a code owner September 23, 2024 20:37
jameslamb
jameslamb approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thanks!

@vyasr
Copy link
Contributor Author

vyasr commented Sep 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9316309 into rapidsai:branch-24.10 Sep 25, 2024
99 checks passed
@vyasr vyasr deleted the fix/find_cudf_cpp branch September 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @jameslamb