Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve aggregation documentation #16822

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Improve aggregation documentation #16822

merged 3 commits into from
Sep 19, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Sep 17, 2024 •
edited
Loading

Description

This PR fixes several documentation issues uncovered while working on #16619. There are no actual code changes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added doc Documentation libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 17, 2024
@PointKernel PointKernel requested a review from a team as a code owner September 17, 2024 22:29
@PointKernel PointKernel removed the improvement Improvement / enhancement to an existing function label Sep 17, 2024
harrism
harrism reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for clarification.

cpp/include/cudf/detail/aggregation/aggregation.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/detail/aggregation/aggregation.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/detail/aggregation/aggregation.hpp Outdated Show resolved Hide resolved
@PointKernel @harrism
Apply suggestions from code review
b604ae3 
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8782a1d into rapidsai:branch-24.10 Sep 19, 2024
98 checks passed
@PointKernel PointKernel deleted the fix-agg-docs branch September 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@davidwendt davidwendt davidwendt approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @harrism @davidwendt