-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward-merge branch-24.08 to branch-24.10 #16813
base: branch-24.10
Are you sure you want to change the base?
Conversation
This is the changes that will be in the cudf-polars point release. --------- Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: David Wendt <dwendt@nvidia.com> Co-authored-by: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com> Co-authored-by: Vyas Ramasubramani <vyasr@nvidia.com> Co-authored-by: brandon-b-miller <brmiller@nvidia.com> Co-authored-by: Bradley Dice <bdice@bradleydice.com> Co-authored-by: Manas Singh <122591937+singhmanas1@users.noreply.github.com> Co-authored-by: Manas Singh <manass@dt01.aselab.nvidia.com>
@@ -43,6 +47,9 @@ python -m pip install \ | |||
"$(echo ./dist/libcudf_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" \ | |||
"$(echo ./dist/pylibcudf_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" | |||
|
|||
rapids-logger "Pin to 1.7.0 Temporarily" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do those changes in a follow-up PR where we unpin and also change the xfail/xpass status of that one test we discussed.
python -m pip install $(echo ./dist/cudf_polars*.whl) | ||
|
||
# TAG=$(python -c 'import polars; print(f"py-{polars.__version__}")') | ||
TAG="py-1.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed now and the above line uncommented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bdice, I think the failures can be fixed by my suggestions, will try it out.
Oh, more merge conflicts! I'll resolve again. |
@mroeschke Can you please let this PR go through before merging any more pylibcudf changes? Or should we run CI locally on this and admin-merge it to avoid further delay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged 24.10 and updated the workflow to point back to branch-24.10 (rather than python-3.12). From my side this looks good.
And the linting issues |
Manual forward merge from 24.08 to 24.10. This PR should not be squashed.