nvCOMP GZIP integration #16770
Merged
nvCOMP GZIP integration #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fea-nvcomp-gzip
|
Unit tests are passing when the integration is enabled. Keeping it disabled by default for now. |
vuule
added
feature request
vuule
commented
Sep 10, 2024
| @@ -447,6 +454,7 @@ std::optional<std::string> is_decompression_disabled(compression_type compressio | |||
| size_t required_alignment(compression_type compression) | |||
| { | |||
| switch (compression) { | |||
| case compression_type::GZIP: | |||
There was a problem hiding this comment.
nvCOMP omitted nvcompGzipRequiredAlignment, so I could not follow the pattern we use for other formats.
We can return the same value as deflate because it's the same compression format; the only difference is an additional header in GZIP.
The alternative would be to use a hard-coded number.
ttnghia
reviewed
Sep 10, 2024
| @@ -447,6 +454,7 @@ std::optional<std::string> is_decompression_disabled(compression_type compressio | |||
| size_t required_alignment(compression_type compression) | |||
| { | |||
| switch (compression) { | |||
| case compression_type::GZIP: | |||
There was a problem hiding this comment.
Why does this require the same alignment as DEFLATE instead of its own alignment?
There was a problem hiding this comment.
#16770 (comment)
we posted at the same time :)
updated that comment to provide context
ttnghia
approved these changes
Sep 10, 2024
mhaseeb123
approved these changes
Sep 10, 2024
|
/merge |
gerashegalov
added a commit
to gerashegalov/cudf
that referenced
this pull request
Oct 2, 2024
This reverts commit 750adca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nvCOMP GZIP integration. Opt-in for now.
Checklist