Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read_csv(header=None) to return int column labels in mode.pandas_compatible #16769

Merged

Conversation

mroeschke
Copy link
Contributor

Description

closes #16766

If the cudf read_csv behavior of always returning string column labels is long standing behavior, we can match the pandas behavior of returning integer column labels in mode.pandas_compatible

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 6, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 6, 2024 20:17
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 26a81b6 into rapidsai:branch-24.10 Sep 9, 2024
95 checks passed
@mroeschke mroeschke deleted the bug/read_csv/header_type branch September 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf.pandas fallback fails with read_csv due to columns being strings
2 participants