Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Series._from_column more consistently to avoid validation #16716

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Use Series._from_column more consistently to avoid validation #16716

merged 1 commit into from
Sep 3, 2024

Conversation

mroeschke
Copy link
Contributor

Description

This modifies cases where _from_column provided the same logic or where 1 column was produced so ._from_column was valid to use

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 30, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 30, 2024 22:53
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e18b537 into rapidsai:branch-24.10 Sep 3, 2024
83 checks passed
@mroeschke mroeschke deleted the ref/series/_from_column branch September 3, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar