-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use merge base when calculating changed files #16709
Use merge base when calculating changed files #16709
Conversation
8c6c79a
to
0143a25
Compare
This reverts commit 4b2189f.
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible enough. Presumably the error before was occurring because when the PR branch was outdated the base SHA pulled from the target branch was not actually in the history of the current branch?
Yes, and in addition, even if it had been present, it wouldn't have correctly calculated the changed files anyway. The |
Description
get-pr-info.outputs.base.sha
does not actually give the merge base, but merely the tip of the target branch. Calculate the merge base and pass it to thechanged-files
step.Checklist