-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slowdown in DataFrame repr in jupyter notebook #16656
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM. I checked that the dataframe in the original issue "hangs" for me without the _ipython_canary_method_should_not_exist_
method raising an AttributeError
and doesn't hang when it does. Do you why that is?
Also, do we need to something similar for pd.Series
?
It is because of this: #16656 (comment)
Nope, Series doesn't have a repr_html, and doesn't seem to have the hangs either. |
/merge |
Description
Fixes: #15747
This PR fixes slow-down in
DataFrame
repr inside a jupyter notebook.Checklist