Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-mangled type names in nvbench output #16649

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Uses the NVBENCH_DECLARE_TYPE_STRINGS feature to produce readable type names in the nvbench output.
Example previous output for cudf::timestamp_ms would appear like this:

| cuda::std::__4::chrono::time_point<cuda::std::__4::chrono::system_clock, cuda::std::__4::chrono::duration<long, cuda::std::__4::ratio<1l, 1000l> > > | 100000 |  23840x | 25.138 us | 21.98% | 20.979 us |  9.54% | 4.767G |  38.134 GB/s |  4.38% |

Adding the nvbench name feature changes this to:

| cudf::timestamp_ms | 100000 |  24752x | 24.387 us | 21.58% | 20.208 us | 3.79% | 4.948G |  39.588 GB/s |  4.55% |

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 23, 2024
@davidwendt davidwendt self-assigned this Aug 23, 2024
@davidwendt davidwendt marked this pull request as ready for review August 23, 2024 18:02
@davidwendt davidwendt requested a review from a team as a code owner August 23, 2024 18:02
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c4591c0 into rapidsai:branch-24.10 Aug 27, 2024
90 checks passed
@davidwendt davidwendt deleted the nvbench-type-names branch August 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants