-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Hide all gtest symbols in cudftestutil (#16546)" #16644
Revert "Hide all gtest symbols in cudftestutil (#16546)" #16644
Conversation
This reverts commit ac42bc8.
/merge |
Summary of the problems that packaging cudftestutil has on libcudf:
|
Outside of conda recipe / packaging semantics which can be loosened, why does this enforce a pinned gtest version? |
To be clear I mean pinned to the same major.minor value. The GTest releases offer no ABI stability between minor releases. So if we build against GTest 1.10 and the users has 1.15 we should expect undefined behavior to occur. |
Proposal to convert cudftestutil into a header-only library is in #16658 |
Description
This reverts commit ac42bc8.
We need to revert #16546 as it broke the gtest builds for cudf. Therefore gtests that actually fail wouldn't properly report an error but silently continue and report as passed.
Checklist