Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow in indexalator pointer logic #16643

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 22, 2024

Description

Fixes integer overflow in the indexalator logic when incrementing/decrementing its data pointer. Any sufficiently large int32 input values used in computing the byte-pointer position causes an overflow when multiplying the value by the byte-width of the underlying index type. For example, this overflow would occur when accessing rows greater than 536,870,912 with an underlying index type of int32 (4-bytes).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 22, 2024
@davidwendt davidwendt self-assigned this Aug 22, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 26, 2024
@davidwendt davidwendt marked this pull request as ready for review August 26, 2024 11:59
@davidwendt davidwendt requested a review from a team as a code owner August 26, 2024 11:59
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 115ddce into rapidsai:branch-24.10 Aug 27, 2024
90 checks passed
@davidwendt davidwendt deleted the indexalator-overflow branch August 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants