Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pragma once in rolling/jit/operation.hpp. #16636

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Move pragma once in rolling/jit/operation.hpp. #16636

merged 1 commit into from
Aug 22, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 21, 2024

Description

I noticed from #16590 (comment) that there was one other file where #pragma once was not at the top. This PR fixes that.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 21, 2024
@bdice bdice mentioned this pull request Aug 21, 2024
Merged
3 tasks
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 21, 2024
@bdice bdice self-assigned this Aug 21, 2024
vyasr
vyasr approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be taken out of draft and merged now?

@bdice bdice marked this pull request as ready for review August 22, 2024 21:47
@bdice bdice requested a review from a team as a code owner August 22, 2024 21:47
@bdice
Copy link
Contributor Author

bdice commented Aug 22, 2024

Great. I'll merge it. Probably doesn't need two reviews for such a small change, and CI is passing.

@bdice
Copy link
Contributor Author

bdice commented Aug 22, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8b20298 into rapidsai:branch-24.10 Aug 22, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@mhaseeb123 mhaseeb123 Awaiting requested review from mhaseeb123 mhaseeb123 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @vyasr