Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add num_multiprocessors utility #16628

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Add num_multiprocessors utility #16628

merged 9 commits into from
Aug 27, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Aug 21, 2024 •
edited
Loading

Description

This PR introduces a new num_multiprocessors utility and moves the existing elements_per_thread host utility to the new cuda.hpp header.

Needed by #16619.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 21, 2024
@PointKernel PointKernel self-assigned this Aug 21, 2024
@PointKernel PointKernel added the 3 - Ready for Review Ready for review by team label Aug 21, 2024
@PointKernel PointKernel marked this pull request as ready for review August 21, 2024 22:35
@PointKernel PointKernel requested a review from a team as a code owner August 21, 2024 22:35
@PointKernel PointKernel requested a review from a team as a code owner August 23, 2024 19:29
@github-actions github-actions bot added the CMake CMake build issue label Aug 23, 2024
harrism
harrism approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring.

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2d494ed into rapidsai:branch-24.10 Aug 27, 2024
86 checks passed
@PointKernel PointKernel deleted the add-num-sms branch August 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@harrism harrism harrism approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @harrism @davidwendt