Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apply_boolean_mask benchmark to nvbench #16616

Merged
merged 12 commits into from
Aug 29, 2024
Merged

Move apply_boolean_mask benchmark to nvbench #16616

merged 12 commits into from
Aug 29, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Reworks the apply_booleam_mask benchmark as an nvbench benchmark under the STREAM_COMPACTION_NVBENCH module. cudf::string_view was added as a type to help measure the performance improvement in a follow on PR for apply_boolean_mask for strings

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 20, 2024
@davidwendt davidwendt self-assigned this Aug 20, 2024
@github-actions github-actions bot added the CMake CMake build issue label Aug 20, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 23, 2024
@davidwendt davidwendt marked this pull request as ready for review August 23, 2024 15:55
@davidwendt davidwendt requested a review from a team as a code owner August 23, 2024 15:55
@davidwendt davidwendt requested review from bdice and vuule August 28, 2024 15:48
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 21d05d7 into rapidsai:branch-24.10 Aug 29, 2024
86 checks passed
@davidwendt davidwendt deleted the apply-bmask-nvbench branch August 29, 2024 20:40
@bdice bdice mentioned this pull request Sep 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @vuule