Reenable arrow tests #16556
Merged
Reenable arrow tests #16556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
tests
|
Keeping as a draft until #16548 (comment) is resolved. |
… to nested nullability isues)
vyasr
force-pushed
the
test/reenable_arrow_tests
branch
from
835eb55
to
88718a4
Compare
davidwendt
reviewed
Aug 16, 2024
|
Failure is unrelated, seems to be caused by #16457. Currently following up offline but I'll open an issue if we need to track this over any longer period of time. |
|
Fix is #16576 |
davidwendt
approved these changes
Aug 16, 2024
|
I know that we normally require 2 reviews, but since this is just adding back tests that were previously disabled I'm going to go ahead and merge with one approval to save people some time. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reenables the tests that were disabled in #16379, converting them to use the new C data interface functions instead of the old libarrow-based ones.
Checklist