Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cudf::empty_like to not include offsets for empty strings columns #16529

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 12, 2024

Description

Fixes cudf::empty_like to only create empty child columns for nested types. The empty child columns are needed to store the types for consistency with cudf::make_empty_column.

Closes #16490

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 12, 2024
@davidwendt davidwendt self-assigned this Aug 12, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 13, 2024
@davidwendt davidwendt marked this pull request as ready for review August 13, 2024 15:39
@davidwendt davidwendt requested a review from a team as a code owner August 13, 2024 15:39
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1f0d0c9 into rapidsai:branch-24.10 Aug 14, 2024
85 checks passed
@davidwendt davidwendt deleted the fix-empty-like branch August 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Have cudf::make_empty_column(cudf::type_id::STRING) return a column with a child column of empty offsets
3 participants