Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DataFrame.sort_values(by=) to select an index level #16519

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Allow DataFrame.sort_values(by=) to select an index level #16519

merged 2 commits into from
Aug 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #14794

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 9, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 9, 2024 02:34
Matt711
Matt711 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke changed the title Allow DataFrame.sort_values(by=) to select and index level Allow DataFrame.sort_values(by=) to select an index level Aug 9, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 16aa0ea into rapidsai:branch-24.10 Aug 9, 2024
82 checks passed
@mroeschke mroeschke deleted the bug/sort_values branch August 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] sort_values fails on groupby aggregation
2 participants
@mroeschke @Matt711