Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve column type and class information in more DataFrame operations #15949

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Preserve column type and class information in more DataFrame operations #15949

merged 4 commits into from
Jun 10, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jun 6, 2024 •
edited
Loading

Description

Narrowing down to a pattern of using ColumnAccessor._from_columns_like_self to preserve the column information and then calling Frame._from_data_like_self to preserve the .index/.name information.

This is specifically for operations that operates column wise and the result should be the same shape as the input.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working non-breaking Non-breaking change cuDF (Python) labels Jun 6, 2024
@mroeschke mroeschke requested a review from a team as a code owner June 6, 2024 20:58
@mroeschke mroeschke requested review from wence- and isVoid June 6, 2024 20:58
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 6, 2024
wence-
wence- approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice cleanup!

python/cudf/cudf/core/indexed_frame.py Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f9b0fc3 into rapidsai:branch-24.08 Jun 10, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/column_preservation branch June 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@wence- wence- wence- approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @wence- @vyasr