Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to be built when stream util is disabled #15933

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Allow tests to be built when stream util is disabled #15933

merged 2 commits into from
Jun 6, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Allows cudf to be built with BUILD_SHARED_LIBS=OFF, CUDA_STATIC_RUNTIME=ON and tests enabled

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels Jun 5, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner June 5, 2024 19:48
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 5, 2024
gerashegalov
gerashegalov approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Verified in spark-rapids-jni Docker container

@ttnghia
Copy link
Contributor

ttnghia commented Jun 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit d91380e into rapidsai:branch-24.08 Jun 6, 2024
72 of 81 checks passed
@robertmaynard robertmaynard deleted the bug/allow_tests_when_stream_util_is_disabled branch June 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertmaynard @ttnghia @gerashegalov @hyperbolic2346 @bdice