Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mixed-like homogeneous types in isin #15771

Merged
merged 3 commits into from
May 17, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15768

There is a possibility that a host array can have object type but contain all values of a homogeneous type, this still cannot be supported by column constructors because cudf doesn't have a true object types, hence this PR introduces a workaround for this problem in isin API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 17, 2024
@galipremsagar galipremsagar self-assigned this May 17, 2024
@galipremsagar galipremsagar requested review from a team as code owners May 17, 2024 05:01
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 17, 2024
@galipremsagar
Copy link
Contributor Author

@ayushdg | @rjzamora Can you checkout these changes and let me know if this unblocks your work?

@rjzamora rjzamora mentioned this pull request May 17, 2024
3 tasks
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for looking into this @galipremsagar !

python/cudf/cudf/core/column/numerical.py Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d10b8e4 into rapidsai:branch-24.06 May 17, 2024
70 checks passed
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] dask-cudf isin errors when passing in a list of values
3 participants