Make nan_as_null behavior consistent across all APIs
#15692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
mroeschke
reviewed
May 7, 2024
| @@ -3200,6 +3207,8 @@ def insert(self, loc, name, value, nan_as_null=None): | |||
| ``null`` values. | |||
| If ``False``, leaves ``np.nan`` values as is. | |||
| """ | |||
| if nan_as_null is no_default: | |||
There was a problem hiding this comment.
Should this be in _insert instead?
There was a problem hiding this comment.
I haven't touched _insert and other private APIs like column constructor because I felt having this handling in public APIs will just be sufficient.
mroeschke
approved these changes
May 8, 2024
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #15679
This PR switches the default of
nan_as_nullto beFalseif pandas compatibility mode is turned on.Forked from #14534
Checklist