Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JSON_READER_OPTION to JSON_READER_OPTION_NVBENCH. #15553

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Rename JSON_READER_OPTION to JSON_READER_OPTION_NVBENCH. #15553

merged 1 commit into from
Apr 17, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 17, 2024

Description

This renames a benchmark executable for JSON_READER_OPTION to indicate that it is an NVBench executable. This naming pattern is significant for our automated benchmarking tools.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner April 17, 2024 16:22
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Apr 17, 2024

/merge

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Apr 17, 2024
@bdice bdice self-assigned this Apr 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Apr 17, 2024

This benchmark was introduced in #15124.

PointKernel
PointKernel approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the fix.

@shrshi
Copy link
Contributor

shrshi commented Apr 17, 2024

Thanks for the quick fix, @bdice. Will look out for benchmark naming conventions in the future :)

@rapids-bot rapids-bot bot merged commit 041eaa4 into rapidsai:branch-24.06 Apr 17, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @shrshi @ttnghia @PointKernel