Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated strings offsets_begin #15454

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove deprecated strings offsets_begin #15454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e846d86
Remove deprecated strings offsets_begin
davidwendt Apr 3, 2024
3da1010
Merge branch 'branch-24.06' into remove-offsets-begin
davidwendt Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions cpp/include/cudf/strings/strings_column_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,28 +85,6 @@ class strings_column_view : private column_view {
*/
[[nodiscard]] column_view offsets() const;

/**
* @brief Return an iterator for the offsets child column.
*
* @deprecated Since 24.04
*
* This automatically applies the offset of the parent.
*
* @return Iterator pointing to the first offset value.
*/
[[deprecated]] offset_iterator offsets_begin() const;

/**
* @brief Return an end iterator for the offsets child column.
*
* @deprecated Since 24.04
*
* This automatically applies the offset of the parent.
*
* @return Iterator pointing 1 past the last offset value.
*/
[[deprecated]] offset_iterator offsets_end() const;

/**
* @brief Returns the number of bytes in the chars child column.
*
Expand Down
10 changes: 0 additions & 10 deletions cpp/src/strings/strings_column_view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ column_view strings_column_view::offsets() const
return child(offsets_column_index);
}

strings_column_view::offset_iterator strings_column_view::offsets_begin() const
{
return offsets().begin<int32_t>() + offset();
}

strings_column_view::offset_iterator strings_column_view::offsets_end() const
{
return offsets().begin<int32_t>() + offset() + size() + 1;
}

int64_t strings_column_view::chars_size(rmm::cuda_stream_view stream) const noexcept
{
if (size() == 0) { return 0L; }
Expand Down
Loading