Bind read_parquet_metadata API to libcudf instead of pyarrow and extract RowGroup information
#15398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
mhaseeb123
added
3 - Ready for Review
3 tasks
mhaseeb123
changed the title
read_parquet_metadata API to libcudf instead of pyarrow and also extract row_group informationread_parquet_metadata API to libcudf instead of pyarrow and extract row_group information
mhaseeb123
changed the title
read_parquet_metadata API to libcudf instead of pyarrow and extract row_group informationread_parquet_metadata API to libcudf instead of pyarrow and extract RowGroup information
mhaseeb123
added
2 - In Progress
galipremsagar
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Thanks for working on this @mhaseeb123 ! Looks like there are some missing columns that is resulting in pytest failures; https://github.com/rapidsai/cudf/actions/runs/8461251922/job/23181884309?pr=15398#step:8:1758
mhaseeb123
added
3 - Ready for Review
Thanks for reviewing the code @galipremsagar. I was already on it and just pushed a fix. The test should pass now. 🙂 |
vuule
reviewed
Apr 2, 2024
Co-authored-by: Vukasin Milovanovic <vmilovanovic@nvidia.com>
galipremsagar
approved these changes
Apr 9, 2024
vuule
reviewed
Apr 16, 2024
vuule
approved these changes
Apr 16, 2024
bdice
reviewed
Apr 17, 2024
bdice
reviewed
Apr 17, 2024
bdice
approved these changes
Apr 17, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cudf.io.read_parquet_metadatais now bound to corresponding libcudf API instead of relying on pyarrow. The libcudf API now also returns high levelRowGroupmetadata to solve #11214. Added additional tests and doc updates as well.More metadata information such
min, maxvalues for each column in each row group can also be extracted and returned if needed. Thoughts?Recommend: Closing #15320 without merging in favor of this PR.
Checklist