Work around a cuFile error when running CSV tests with memcheck #15293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
wence-
reviewed
Mar 14, 2024
| // Workaround for https://github.com/rapidsai/cudf/issues/14140, where cuFileDriverOpen errors | ||
| // out if no CUDA calls have been made before it. This is a no-op if the CUDA context is | ||
| // already initialized | ||
| cudaFree(0); |
There was a problem hiding this comment.
I believe this is a cufile bug (or at least a documentation bug about the necessary preconditions for cuFileDriverOpen), tracked internally as bug 4562392.
davidwendt
approved these changes
Mar 14, 2024
PointKernel
approved these changes
Mar 16, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 1, 2024
Issue #14140 Follow-up on #15293 Moving the `cudaFree(0)` call to a function called both by file `datasource` and `data_sink`. Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - David Wendt (https://github.com/davidwendt) - Yunsong Wang (https://github.com/PointKernel) - Nghia Truong (https://github.com/ttnghia) URL: #15335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14140
Added a no-op CUDA call before creating a
kvikio::FileHandleto avoid the error incuFileDriverOpen.Checklist