Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Columns.astype & cudf.dtype #15125

Merged
merged 16 commits into from
Mar 6, 2024
Merged

Clean up Columns.astype & cudf.dtype #15125

merged 16 commits into from
Mar 6, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • Able to remove pandas_dtypes_alias_to_cudf_alias by using cudf.dtype in Column.astype
  • Simplified some branches in Column.astype

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 23, 2024 01:49
shwina
shwina approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. One suggestion to improve an older error message.

isVoid
isVoid approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pretty neat.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5838d7b into rapidsai:branch-24.04 Mar 6, 2024
74 checks passed
@mroeschke mroeschke deleted the ref/astype branch March 6, 2024 21:26
@mroeschke mroeschke mentioned this pull request Mar 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@isVoid isVoid isVoid approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @shwina @isVoid @vyasr