-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pandas-2.2
in cudf
#15100
Add support for pandas-2.2
in cudf
#15100
Conversation
return pd.Series( | ||
host_values, | ||
self.to_arrow(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in noting in the future we should pass pandas a numpy array instead of a pyarrow array and pandas.Series
treats pyarrow arrays as objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If/when we decide to test against the minimum supported pandas version (pandas 2.0) would we have to add any of these checks back in?
The current |
@@ -65,7 +65,7 @@ dependencies: | |||
- nvcomp==3.0.5 | |||
- nvtx>=0.2.1 | |||
- packaging | |||
- pandas>=2.0,<2.1.5dev0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right pinning, or should we go with <2.3.0dev0
? Do we expect patch releases to break us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel various fixes are going into 2.2.1
that may have an impact on us, but would defer to @mroeschke on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I fixed various issues @galipremsagar found in pandas 2.2.1 (coming out next week) which there are xfails for so the update will break the test suite. We should probably relax the pin in a follow up PR when that's out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a question about pinnings that we should resolve before merging.
85485a5
to
3efb4f8
Compare
/merge |
@shwina @raydouglass @mroeschke In the interest of time, I upgraded the pinnings to include the latest patch release of pandas-2.2.1 too. If you have any concerns on these changes, let me know I'll address it in a follow-up pr. |
Description
This PR:
pandas-2.2
incudf
by upgrading the upper bound pinnings.Checklist