Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link for developer guide #15025

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix broken link for developer guide #15025

merged 1 commit into from
Feb 14, 2024

Conversation

sanjana098
Copy link
Contributor

@sanjana098 sanjana098 commented Feb 12, 2024 •
edited by harrism
Loading

Description

Closes #14991

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Feb 12, 2024
@davidwendt
Copy link
Contributor

/ok to test

bdice
bdice approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. cc: @vyasr for awareness

@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Feb 12, 2024
harrism
harrism approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix!

@davidwendt
Copy link
Contributor

/ok to test

@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit ee1c768 into rapidsai:branch-24.04 Feb 14, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Link to libcudf developer_guide is broken in cuDF developer_guide
4 participants
@sanjana098 @davidwendt @harrism @bdice