Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sanitizer check for a test case testORCReadAndWriteForDecimal128 #14897

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

res-life
Copy link
Contributor

Description

Enable sanitizer check for test case TableTest#testORCReadAndWriteForDecimal128
closes NVIDIA/spark-rapids-jni#1338

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

The dependency cuDF issue was closed, so enable enable sanitizer check for this test case.

Signed-off-by: Chong Gao <res_life@163.com>
@res-life res-life added 3 - Ready for Review Ready for review by team tests Unit testing for project 5 - Ready to Merge Testing and reviews complete, ready to merge Java Affects Java cuDF API. non-breaking Non-breaking change labels Jan 26, 2024
@res-life res-life requested a review from a team as a code owner January 26, 2024 11:51
Copy link

copy-pr-bot bot commented Jan 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@res-life res-life self-assigned this Jan 26, 2024
@res-life res-life added bug Something isn't working and removed Java Affects Java cuDF API. labels Jan 26, 2024
@res-life
Copy link
Contributor Author

/ok to test

@res-life
Copy link
Contributor Author

Maybe we should re-target 24.04? @GaryShen2008

@res-life res-life changed the base branch from branch-24.02 to branch-24.04 January 29, 2024 02:16
@res-life
Copy link
Contributor Author

/ok to test

@res-life
Copy link
Contributor Author

/ok to test

@res-life
Copy link
Contributor Author

res-life commented Feb 8, 2024

/ok to test

@davidwendt davidwendt changed the title Enable sanitizer check for a test case Enable sanitizer check for a test case testORCReadAndWriteForDecimal128 Feb 8, 2024
@res-life
Copy link
Contributor Author

res-life commented Feb 9, 2024

/ok to test

@res-life
Copy link
Contributor Author

/ok to test

@res-life
Copy link
Contributor Author

@jlowe Need a approving review by reviewers with write access.

@ttnghia
Copy link
Contributor

ttnghia commented Feb 19, 2024

My approval should have write access.

@ttnghia
Copy link
Contributor

ttnghia commented Feb 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6a9cefd into rapidsai:branch-24.04 Feb 19, 2024
68 checks passed
@res-life res-life deleted the enable-sanitizer-case branch February 21, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Compute Sanitizer reports errors for the TableTest#testORCReadAndWriteForDecimal128 test
2 participants