Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pytest-cases<3.8.2 #14756

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Pin pytest-cases<3.8.2 #14756

merged 1 commit into from
Jan 16, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jan 12, 2024 •
edited by karthikeyann
Loading

Description

Appears in the pytest-cases 3.8.2, there's a requirement that automatically finding cases must be in a file named test_*, when historically looks like we use bench_*

https://github.com/smarie/python-pytest-cases/pull/320/files

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2024
@mroeschke mroeschke requested review from a team as code owners January 12, 2024 23:30
@mroeschke mroeschke requested review from wence- and shwina January 12, 2024 23:30
@github-actions github-actions bot added the conda label Jan 12, 2024
@karthikeyann
Copy link
Contributor

/merge

1 similar comment
@ttnghia
Copy link
Contributor

ttnghia commented Jan 14, 2024

/merge

@bdice bdice mentioned this pull request Jan 16, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot merged commit 726a7f3 into rapidsai:branch-24.02 Jan 16, 2024
67 checks passed
@mroeschke mroeschke deleted the pin/pytest_cases branch January 16, 2024 15:47
@jakirkham
Copy link
Member

Thanks all! 🙏

@jameslamb jameslamb mentioned this pull request Jan 16, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jan 18, 2024
@jameslamb
fix benchmarks compatibility with newer pytest-cases (#14764)
eeee795 
Reverts changes from #14756.

* updates `cudf`'s tests to be compatible with the latest `pytest-cases` ([version 3.8.2](https://pypi.org/project/pytest-cases/#history))
* puts a floor of `pytest-cases>=3.8.2` on that project to be sure older versions aren't used

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ray Douglass (https://github.com/raydouglass)

URL: #14764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mroeschke @karthikeyann @ttnghia @jakirkham @raydouglass @bdice