Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable intermediate proxies to be picklable #14752

Merged
merged 13 commits into from
Jan 20, 2024
Merged

Enable intermediate proxies to be picklable #14752

merged 13 commits into from
Jan 20, 2024

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jan 12, 2024

Description

Closes #14738

Enables intermediate proxy types to be pickled, same as final proxy types.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 12, 2024
@shwina shwina marked this pull request as ready for review January 12, 2024 13:52
@shwina shwina requested a review from a team as a code owner January 12, 2024 13:52
@shwina shwina marked this pull request as draft January 12, 2024 16:34
@shwina
Copy link
Contributor Author

shwina commented Jan 12, 2024

/ok to test

@shwina shwina added non-breaking Non-breaking change bug Something isn't working labels Jan 12, 2024
@shwina
Copy link
Contributor Author

shwina commented Jan 16, 2024

/ok to test

@shwina shwina marked this pull request as ready for review January 18, 2024 14:54
bdice
bdice approved these changes Jan 18, 2024
View reviewed changes
python/cudf/cudf/pandas/fast_slow_proxy.py Show resolved Hide resolved
python/cudf/cudf/pandas/module_accelerator.py Outdated Show resolved Hide resolved
vyasr
vyasr requested changes Jan 18, 2024
View reviewed changes
python/cudf/cudf/core/_internals/where.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Show resolved Hide resolved
python/cudf/cudf/testing/testing.py Outdated Show resolved Hide resolved
@shwina shwina requested a review from vyasr January 19, 2024 18:09
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Jan 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1994280 into rapidsai:branch-24.02 Jan 20, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't pickle cudf pandas GroupBy objects
3 participants
@shwina @vyasr @bdice