Reorganize ORC reader into multiple files and perform some small fixes to cuIO code #14665
Conversation
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
ttnghia
added
feature request
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Co-authored-by: Vukasin Milovanovic <vmilovanovic@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
This reverts commit 1b14b96. # Conflicts: # cpp/src/io/orc/reader_impl.cu
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
| case orc::STRING: | ||
| case orc::BINARY: | ||
| case orc::VARCHAR: | ||
| case orc::CHAR: |
There was a problem hiding this comment.
Can we add explicit [[fallthrough]] to all fallthrough cases?
There was a problem hiding this comment.
Should we only use [[fallthrough]] for non-empty cases?
I previously overused it, at least based on
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-break
https://en.cppreference.com/w/cpp/language/attributes/fallthrough
There was a problem hiding this comment.
I vaguely remember that @vuule has some argument against using [[fallthrough]]?
There was a problem hiding this comment.
I can see how [[fallthrough]] might feel overused from that example. I'm usually in favor of using it but I will defer to you on choosing whether to use it here.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2021-2023, NVIDIA CORPORATION. | |||
| * Copyright (c) 2021-2024, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
This file has some small fixes with compiler markup.
| @@ -0,0 +1,42 @@ | |||
| /* | |||
There was a problem hiding this comment.
The new files contain extracted code from reader_impl.hpp/cu.
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
@ttnghia I think this needs a more descriptive PR title. |
ttnghia
changed the title
I've changed the title a little bit. Please feel free to recommend any better one. |
I guess I meant the "refactor ORC reader" part is a bit vague and is likely to occur again. |
ttnghia
changed the title
ttnghia
changed the title
|
/merge |
This refactors the ORC reader, moving ORC code around to facilitate the upcoming support for chunked reading of the input files.
No new functionality/implementation is added in this PR. Only the existing code is moving around, except that some small issues of the related ORC/cuIO code are also fixed.