Defer PTX file load to runtime #13690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
bdice
approved these changes
Jul 12, 2023
shwina
approved these changes
Jul 12, 2023
vyasr
approved these changes
Jul 13, 2023
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
bdice
approved these changes
Jan 5, 2024
|
/ok to test |
|
/ok to test |
vyasr
reviewed
Jan 10, 2024
| text=True, | ||
| cwd="/", | ||
| ) | ||
| assert output.returncode == 0 |
There was a problem hiding this comment.
Is the test failing because there's a nonzero return code in this case?
|
/ok to test |
|
/ok to test |
3 tasks
|
/ok to test |
|
@brandon-b-miller I resolved the conflicts. Hopefully I got the styling right, otherwise a quick pre-commit run might be needed. |
vyasr
approved these changes
Jan 17, 2024
vyasr
reviewed
Jan 17, 2024
vyasr
reviewed
Jan 17, 2024
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where cuDF fails to import on machines with no NVIDIA GPU present.
cc @shwina